Skip to content

Fix: Prevent accidental key clicks during horizontal scrolling in mobile UI #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
DeveloperAmrit wants to merge 1 commit into from
+7 −52
Closed

Fix: Prevent accidental key clicks during horizontal scrolling in mobile UI #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 3 additions & 48 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions src/components/Trackpad/ExtraKeys.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,12 +45,12 @@ const EXTRA_KEYS: { label: string; key: string }[] = [
export const ExtraKeys: React.FC<ExtraKeysProps> = ({ sendKey, onInputFocus: _onInputFocus }) => {
const [isPlaying, setIsPlaying] = useState(false);

const handleInteract = (e: React.PointerEvent, key: string) => {
const handleInteract = (e: React.MouseEvent, key: string) => {
e.preventDefault();
sendKey(key);
};

const handlePlayPause = (e: React.PointerEvent) => {
const handlePlayPause = (e: React.MouseEvent) => {
e.preventDefault();
if (isPlaying) {
sendKey("audiopause");
Expand All @@ -71,15 +71,15 @@ export const ExtraKeys: React.FC<ExtraKeysProps> = ({ sendKey, onInputFocus: _on
key={key}
type="button"
className="btn btn-sm btn-neutral min-w-[2.5rem] shrink-0"
onPointerDown={(e) => handleInteract(e, key)}
onClick={(e) => handleInteract(e, key)}
>
{label}
</button>
))}
<button
type="button"
className="btn btn-sm btn-neutral min-w-[2.5rem] shrink-0"
onPointerDown={handlePlayPause}
onClick={handlePlayPause}
title={isPlaying ? "Pause" : "Play"}
>
{isPlaying ? "Pause" : "Play"}
Expand Down