Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustc: update to 1.83.0 #9036

Merged
merged 1 commit into from
Dec 24, 2024
Merged

rustc: update to 1.83.0 #9036

merged 1 commit into from
Dec 24, 2024

Conversation

MingcongBai
Copy link
Member

@MingcongBai MingcongBai commented Dec 22, 2024

Topic Description

  • rustc: update to 1.83.0
    • Track patches at AOSC-Tracking/rust @ aosc/v1.83.0
      (HEAD: 68757f859f724374107416d1c0b212ce9126aa71).
    • FIXME: Using local bootstrap tarball as we missed a release - rustc needs
      to bootstrap from an adjacent release.

Package(s) Affected

  • rustc: 1:1.83.0

Security Update?

No

Build Order

#buildit rustc

Test Build(s) Done

Primary Architectures

  • AMD64 amd64
  • AArch64 arm64
  • LoongArch 64-bit loongarch64

Secondary Architectures

  • Loongson 3 loongson3
  • PowerPC 64-bit (Little Endian) ppc64el
  • RISC-V 64-bit riscv64

@MingcongBai MingcongBai added the upgrade Topic/issue involves a package upgrade label Dec 22, 2024
@MingcongBai MingcongBai force-pushed the rustc-1.83.0 branch 2 times, most recently from f8b6450 to 098d730 Compare December 22, 2024 13:28
@MingcongBai MingcongBai marked this pull request as ready for review December 22, 2024 13:30
@jiegec
Copy link
Member

jiegec commented Dec 23, 2024

Probably we should upgrade to 1.82.0 first.

@MingcongBai
Copy link
Member Author

Probably we should upgrade to 1.82.0 first.

I have already changed config.toml to use a downloaded bootstrap toolchain, unless I made mistakes somewhere...

@jiegec
Copy link
Member

jiegec commented Dec 23, 2024

Let's try again with pub -> pub(crate).

@jiegec
Copy link
Member

jiegec commented Dec 23, 2024

Probably we should upgrade to 1.82.0 first.

I have already changed config.toml to use a downloaded bootstrap toolchain, unless I made mistakes somewhere...

[�[96mINFO�[0m]:  �[1mGenerating config.toml ...�[0m
[�[96mINFO�[0m]:  �[1mArchitecture loongson3 matches loongson3: taking true branch.�[0m
[�[96mINFO�[0m]:  �[1mExtracting bootstrapped Stage 1 Rust toolchain...�[0m
bsdtar: Error opening archive: Failed to open '/var/cache/acbs/build/acbs._wzdnw6p/rustc-bootstrap-1.83.0-loongson3.tar.xz'
�[0mIn file included from �[1m/usr/bin/autobuild:13
�[0m                 from �[1m/usr/lib/autobuild4/proc/50-build-exec.sh:13
autobuild/prepare:66: �[0mIn function `�[1msource':
autobuild/prepare:66: �[91merror: �[39mcommand exited with �[93m1�[39m�[0m
   65 |     abinfo "Extracting bootstrapped Stage 1 Rust toolchain..."�[0m
�[1m>  66 |     bsdtar xf "$SRC_PARENT"/rustc-bootstrap-${PKGVER}-${CROSS:-$ARCH}.tar.xz \�[0m
   67 |         -C "$SRC_PARENT"�[0m

@jiegec
Copy link
Member

jiegec commented Dec 23, 2024

Something wrong with fp16 on loongarch64 again:

�[K[RUSTC-TIMING] memchr test:false 1.350
�[1m�[36m    Building�[0m [===========>               ] 18/39: rustc-demangle, alloc, co...
�[K�[1m�[33mwarning�[0m�[1m:�[0m `memchr` (lib) generated 45 warnings (3 duplicates)
�[1m�[36m    Building�[0m [============>              ] 19/39: rustc-demangle, alloc, co...
�[Krustc-LLVM ERROR: Cannot select: 0x7fffc01ed780: i64 = fp_to_fp16 0x7fffc053edb0
  0x7fffc053edb0: f32,ch = CopyFromReg 0x7fffc037e820, Register:f32 %5
    0x7fffc017bd80: f32 = Register %5
In function: _ZN17compiler_builtins5float6extend13__extendhfsf217h18693198bf4844c6E
�[1m�[36m    Building�[0m [============>              ] 19/39: rustc-demangle, alloc, co...
�[K[RUSTC-TIMING] compiler_builtins test:false 3.711
�[1m�[36m    Building�[0m [============>              ] 19/39: rustc-demangle, alloc, co...

Did not run successfully: exit status: 101

@MingcongBai
Copy link
Member Author

Something wrong with fp16 on loongarch64 again:

�[K[RUSTC-TIMING] memchr test:false 1.350
�[1m�[36m    Building�[0m [===========>               ] 18/39: rustc-demangle, alloc, co...
�[K�[1m�[33mwarning�[0m�[1m:�[0m `memchr` (lib) generated 45 warnings (3 duplicates)
�[1m�[36m    Building�[0m [============>              ] 19/39: rustc-demangle, alloc, co...
�[Krustc-LLVM ERROR: Cannot select: 0x7fffc01ed780: i64 = fp_to_fp16 0x7fffc053edb0
  0x7fffc053edb0: f32,ch = CopyFromReg 0x7fffc037e820, Register:f32 %5
    0x7fffc017bd80: f32 = Register %5
In function: _ZN17compiler_builtins5float6extend13__extendhfsf217h18693198bf4844c6E
�[1m�[36m    Building�[0m [============>              ] 19/39: rustc-demangle, alloc, co...
�[K[RUSTC-TIMING] compiler_builtins test:false 3.711
�[1m�[36m    Building�[0m [============>              ] 19/39: rustc-demangle, alloc, co...

Did not run successfully: exit status: 101

Dang it! We had a patch for 1.82, not sure if still useful:

AOSC-Tracking/rustc@8438616

@jiegec
Copy link
Member

jiegec commented Dec 23, 2024

Is it time to switch to llvm 19 for loongarch?

@MingcongBai
Copy link
Member Author

Is it time to switch to llvm 19 for loongarch?

Possibly. Have a go in this topic (choosing LLVM 19 as the compiler).

@jiegec
Copy link
Member

jiegec commented Dec 23, 2024

Now linked to llvm 19:

        linux-vdso.so.1 (0x00007f0758e22000)
        librustc_driver-e2db29cab5dfae99.so => /usr/lib/librustc_driver-e2db29cab5dfae99.so (0x00007f0754e00000)
        libc.so.6 => /usr/lib/glibc-hwcaps/x86-64-v3/libc.so.6 (0x00007f0754c39000)
        libLLVM.so.19.1 => /usr/lib/libLLVM.so.19.1 (0x00007f074d400000)
        libstdc++.so.6 => /usr/lib/libstdc++.so.6 (0x00007f074d000000)
        libgcc_s.so.1 => /usr/lib/libgcc_s.so.1 (0x00007f0758d8f000)
        libm.so.6 => /usr/lib/glibc-hwcaps/x86-64-v3/libm.so.6 (0x00007f0754b8b000)
        /lib64/ld-linux-x86-64.so.2 => /usr/lib64/ld-linux-x86-64.so.2 (0x00007f0758e24000)
        libffi.so.8 => /usr/lib/libffi.so.8 (0x00007f0758d7d000)
        libedit.so.0 => /usr/lib/libedit.so.0 (0x00007f0758d3e000)
        libz.so.1 => /usr/lib/libz.so.1 (0x00007f0758d1a000)
        libzstd.so.1 => /usr/lib/glibc-hwcaps/x86-64-v3/libzstd.so.1.5.6 (0x00007f0754a9f000)
        libxml2.so.2 => /usr/lib/libxml2.so.2 (0x00007f074ce98000)
        libncursesw.so.6 => /usr/lib/libncursesw.so.6 (0x00007f074d389000)
        liblzma.so.5 => /usr/lib/liblzma.so.5 (0x00007f074d349000)

@aosc-buildit-bot
Copy link
Contributor

Dickens-topic report has been uploaded to pastebin as paste fe447948-8ead-41f2-9f43-007e8657f860.

- Track patches at AOSC-Tracking/rust @ aosc/v1.83.0
  (HEAD: ac98d84d26ce1305335275bb75bf3d55beed4870).
- FIXME: Using local bootstrap tarball as we missed a release - rustc needs
  to bootstrap from an adjacent release.
- Switch LLVM version to 19, this fixes an issue related to fp16 on LoongArch.
@MingcongBai
Copy link
Member Author

LGTM, successfully built oma 1.14-alpha.0 (master):

image

@jiegec jiegec merged commit bc74589 into stable Dec 24, 2024
@jiegec jiegec deleted the rustc-1.83.0 branch December 24, 2024 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
upgrade Topic/issue involves a package upgrade
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants