Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Watchman Survey 20241212 #8942

Open
wants to merge 10 commits into
base: stable
Choose a base branch
from
Open

Conversation

chenx97
Copy link
Member

@chenx97 chenx97 commented Dec 12, 2024

Topic Description

  • watchman: update to 2024.12.09.00
    ... and introduce a package group to track dependencies that must
    have the same version as watchman itself.
  • edencommon: new, 2024.12.09.00
  • fb303: new, 2024.12.09.00
  • fbthrift: new, 2024.12.09.00
  • wangle: new, 2024.12.09.00
  • mvfst: new, 2024.12.09.00
  • fizz: new, 2024.12.09.00
  • folly: new, 2024.12.09.00
  • cpptoml: new, 0.1.2
  • fast-float: new, 7.0.0

Package(s) Affected

  • cpptoml: 0.1.2
  • edencommon: 2024.12.09.00
  • fast-float: 7.0.0
  • fb303: 2024.12.09.00
  • fbthrift: 2024.12.09.00
  • fizz: 2024.12.09.00
  • folly: 2024.12.09.00
  • mvfst: 2024.12.09.00
  • wangle: 2024.12.09.00
  • watchman: 2024.12.09.00

Security Update?

No

Build Order

#buildit fast-float cpptoml folly fizz mvfst wangle fbthrift fb303 edencommon watchman

Test Build(s) Done

Primary Architectures

  • AMD64 amd64
  • AArch64 arm64
  • LoongArch 64-bit loongarch64

Secondary Architectures

  • Loongson 3 loongson3
  • PowerPC 64-bit (Little Endian) ppc64el
  • RISC-V 64-bit riscv64

@chenx97 chenx97 added survey Topic is a survey of a set or category of packages upgrade Topic/issue involves a package upgrade labels Dec 12, 2024
@chenx97 chenx97 force-pushed the watchman-survey-2024.12.09.00 branch 3 times, most recently from a3d11ec to d085463 Compare December 16, 2024 09:33
@chenx97 chenx97 force-pushed the watchman-survey-2024.12.09.00 branch 2 times, most recently from 9368c8b to 23b9220 Compare December 20, 2024 11:19
@chenx97 chenx97 force-pushed the watchman-survey-2024.12.09.00 branch from 23b9220 to 58781f3 Compare December 21, 2024 09:22
@chenx97 chenx97 marked this pull request as ready for review December 21, 2024 12:19
@chenx97 chenx97 requested a review from MingcongBai December 21, 2024 12:22
PKGNAME=fbthrift
PKGSEC=net
PKGDEP="fizz fmt folly gflags glog mvfst wangle xxhash zlib zstd"
PKGDES="RPC and serialization framework plus a code generator."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wh... what? I'm so confused.

Either way, at least drop the period point.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the upstream's README: Serialization and RPC framework for service communication

PKGSEC=net
PKGDEP="fmt gflags glog libsodium openssl"
BUILDDEP="folly gtest"
PKGDES="A fast, asynchronous TLS 1.3 implementation written in C++14."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Asynchronous TLS 1.3 implementation in C++

@@ -1,8 +1,14 @@
PKGNAME=watchman
PKGSEC=utils
PKGDEP="pcre python-3"
PKGDEP="boost edencommon fmt folly gflags glog libevent openssl pcre python-3"
BUILDDEP="cpptoml gtest llvm rustc"
PKGDES="An inotify-based file watching and job triggering command line utility"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A file-watching and job-triggering utility based on inotify

@@ -0,0 +1,2 @@
abinfo "Setting DESTDIR for Python3 binding installation ..."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Python 3

@@ -0,0 +1,7 @@
PKGNAME=cpptoml
PKGSEC=libs
PKGDES="Header-only TOML v0.5.0 (2018) config file parser"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

configuration file, do not abbreviate (especially informally) in PKGDES

PKGSEC=utils
PKGDEP="fb303 folly gflags glog"
BUILDDEP="gtest"
PKGDES="A supporting library used by watchman and sapling SCM"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Support library for... (check project documentation for capitalisation)

PKGNAME=fast-float
PKGSEC=libs
PKGDEP="glibc"
PKGDES="Fast header-only string-to-float for C and C++"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drop "Fast", the user will decide.

PKGSEC=libs
PKGDEP="boost double-conversion fmt gflags glog lz4 openssl snappy xz zlib"
BUILDDEP="fast-float"
PKGDES="A C++ library interfacing many other libraries, used by projects made by Facebook"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thousand words written, not a single idea came out.

C++17 API component library

Should suffice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
survey Topic is a survey of a set or category of packages upgrade Topic/issue involves a package upgrade
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants