Remove filter in avif_fuzztest_properties #2575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maryla-uc
approved these changes
Jan 17, 2025
y-guyon
force-pushed
the
remove_fuzztest_filter
branch
from
2a79dcc to
db37f71
Compare
Avoid failures due to "Ineffective use of Filter()".
y-guyon
force-pushed
the
remove_fuzztest_filter
branch
from
db37f71 to
03daa30
Compare
wantehchang
reviewed
Jan 17, 2025
| // Don't return known properties. | ||
| return fuzztest::Filter( | ||
| [](const TestProp& prop) { | ||
| return !avifIsKnownPropertyType(prop.fourcc.data()); |
There was a problem hiding this comment.
A random fourcc is unlikely to be a known property type. So this Filter should be okay.
| } | ||
|
|
||
| inline auto ArbitraryUUIDProp() { | ||
| auto fourcc = fuzztest::Just(std::array<uint8_t, 4>{'u', 'u', 'i', 'd'}); | ||
| auto uuid = fuzztest::Arbitrary<std::array<uint8_t, 16>>(); | ||
| auto body = fuzztest::Arbitrary<std::vector<uint8_t>>(); | ||
| // Don't use invalid UUIDs. | ||
| return fuzztest::Filter( | ||
| [](const TestProp& prop) { return avifIsValidUUID(prop.uuid.data()); }, |
There was a problem hiding this comment.
I guess a random 16-byte is likely to be an invalid UUID more than 90% of the time in the first 100 tries. It may make sense to replace line 87 (auto uuid = fuzztest::Arbitrary<std::array<uint8_t, 16>>();) with custom code that generates a valid UUID.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid failures due to "Ineffective use of Filter()".