Replace ipmaArray with avifItemPropertyAssociation #2555

y-guyon · 2025-01-06T14:54:58Z

Go from 16 associations maximum per item to 127 unique properties maximum across all items.
Add units in avifpropertytest.
Fix avif_fuzztest_properties.

Fix for https://github.com/AOMediaCodec/libavif/actions/runs/12631930770/job/35194606943?pr=2551.

Go from 16 associations maximum per item to 127 unique properties maximum across all items. Add units in avifpropertytest. Fix avif_fuzztest_properties.

src/write.c

[skip ci]

wantehchang

Yannis: I didn't really review this pull request. I was just curious how we enforce the 127 unique properties maximum and saw a minor issue with the MAX_PROPERTY_INDEX macro.

src/write.c

y-guyon · 2025-01-07T09:18:10Z

how we enforce the 127 unique properties maximum

Here:

libavif/src/write.c

Line 447 in e9a27bc

    
           AVIF_CHECKERR(dedup->nextIndex < MAX_PROPERTY_INDEX, AVIF_RESULT_INVALID_ARGUMENT);

y-guyon added 2 commits January 6, 2025 15:48

Replace ipmaArray with avifItemPropertyAssociation

834d9c3

Go from 16 associations maximum per item to 127 unique properties maximum across all items. Add units in avifpropertytest. Fix avif_fuzztest_properties.

Add cast for MSVC

3bc27d4

y-guyon requested a review from maryla-uc January 6, 2025 15:14

maryla-uc approved these changes Jan 6, 2025

View reviewed changes

src/write.c Outdated Show resolved Hide resolved

Add parens for readability

00e55d2

[skip ci]

y-guyon merged commit 2de9287 into AOMediaCodec:main Jan 6, 2025

y-guyon deleted the props branch January 6, 2025 15:44

wantehchang reviewed Jan 6, 2025

View reviewed changes

src/write.c Show resolved Hide resolved

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Replace ipmaArray with avifItemPropertyAssociation #2555

Replace ipmaArray with avifItemPropertyAssociation #2555

y-guyon commented Jan 6, 2025 •

edited

Loading

wantehchang left a comment

y-guyon commented Jan 7, 2025

Replace ipmaArray with avifItemPropertyAssociation #2555

Replace ipmaArray with avifItemPropertyAssociation #2555

Conversation

y-guyon commented Jan 6, 2025 • edited Loading

wantehchang left a comment

Choose a reason for hiding this comment

y-guyon commented Jan 7, 2025

y-guyon commented Jan 6, 2025 •

edited

Loading