Properly check for cache hits. #2172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
y-guyon
approved these changes
May 23, 2024
wantehchang
requested changes
May 23, 2024
There was a problem hiding this comment.
Vincent: Searching for "cache-hit" in https://github.com/actions/cache, I found that we are testing cache-hit in the same way as the sample code.
Are you sure this pull request is necessary?
|
Let's put this one on the back burner, maybe I thgought it was necessary because of a cache miss. |
cache-hit is a boolean.
This reverts commit 624e365.
|
The cache hit was not checked properly: the answer from the action has to be sent back to the main workflow. This bug was just introduced in #2174 |
y-guyon
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
steps.cache-ext.outputs.cache-hit != 'true'is actually always true becausesteps.cache-ext.outputs.cache-hitdoes not exist anymore, as the stepcache-hitis now hidden in the cache action. Thecache-hitinformation has to be sent back from the cache action.