Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run ci-windows-installed.yml on every pull request #2149

Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions .github/workflows/ci-windows-installed.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,7 @@
# * TODO: use proper installations of libgav1, libsharpyuv and SVT once released.

name: CI Windows Installed
on:
push:
branches:
- main
on: [push, pull_request]
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another option is to run ci-windows.yml on every pull request. Would you prefer that instead?

Right now ci-windows.yml is run under the following conditions:

on:
  push:
  pull_request:
    paths:
      - '.github/workflows/ci-windows.yml'
      - '**CMakeLists.txt'
      - 'cmake/**'
      - 'ext/**'

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think the current PR is fine.


permissions:
contents: read
Expand Down
Loading