obu: Use uint32_t for obu_forbidden_bits #2146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids a type conversion.
|
This also fixes CI failures such as this one: https://github.com/AOMediaCodec/libavif/actions/runs/8931900623/job/24534782963 |
|
Were the CI actions not run on #2144? |
They ran and passed. But it seems like the windows CI bots only run on push (and on PRs only when certain files are changed). I don't know why they are set up this way, may be it is too slow to run on every PR? https://github.com/AOMediaCodec/libavif/blob/main/.github/workflows/ci-windows.yml#L16 |
|
Thank you. I will propose to run ci-windows-installed.yml on every PR. |
|
See #2149. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids a type conversion.