-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add installation instructions #2085
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Maybe Windows pre-built binaries section could be moved next to windows intall section?
The "Prebuilt Library" section still refers to the appveyor binaries that are at HEAD. I consider it to be dev so let's leave it there for now. I added a mention to the official release page though. |
README.md
Outdated
You can also download the official windows binaries on the | ||
[release](https://github.com/AOMediaCodec/libavif/releases) page. | ||
|
||
### OSX |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: change "OSX" to "macOS" (the current name of the OS).
README.md
Outdated
```sh | ||
sudo apt install libavif-dev | ||
``` | ||
RedHat-based distributions: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: "Red Hat" is spelled as two words.
Does it also make sense to mention libavif packages are also available in MSYS2 (Windows) and MacPorts? |
@kmilos sure, what are the instructions to install on those platforms? Thx |
|
I always thought those were noisy. @wantehchang , do you want to add https://repology.org/badge/vertical-allrepos/libavif.svg?exclude_unsupported=1&columns=3&exclude_sources=modules,site&header=libheif%20packaging%20status ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you (and Miloš) for adding the package installation instructions!
@@ -48,6 +53,13 @@ Red Hat-based distributions: | |||
sudo yum -y install libavif | |||
``` | |||
|
|||
### MinGW |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: MinGW should be moved to the "Windows" section, at least next to it.
Vincent: I think it's good to add the libavif packaging status. I agree that table may grow too big, and it is more useful to us (libavif maintainers) than the end users. We can address that by setting up the link so that it opens a new page. |
This should fix #2081