Do not use env:NUMBER_OF_PROCESSORS for MinGW #2076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since CMake 3.29 (which is on MingW), we can omit the parameter. https://cmake.org/cmake/help/latest/manual/ctest.1.html "Otherwise, if the value is omitted, parallelism is limited by the number of processors, or 2, whichever is larger."
y-guyon
approved these changes
Mar 25, 2024
wantehchang
reviewed
Mar 25, 2024
| @@ -82,4 +82,4 @@ jobs: | |||
| run: ninja | |||
| - name: Run AVIF Tests | |||
| working-directory: ./build | |||
| run: ctest -j $Env:NUMBER_OF_PROCESSORS --output-on-failure | |||
There was a problem hiding this comment.
Thanks for the fix. Do you know why $Env:NUMBER_OF_PROCESSORS suddenly stopped working recently?
There was a problem hiding this comment.
No idea, maybe @kmilos has an idea? Thx
There was a problem hiding this comment.
Not really, sorry... Perhaps a syntax thing? $Env:NUMBER_OF_PROCESSORS is powershell, while the default shell for this job is msys2 (bash)...
There was a problem hiding this comment.
Yup: https://github.com/AOMediaCodec/libavif/actions/runs/8411426945/job/23030997022#step:10:7
This should be just $NUMBER_OF_PROCESSORS in case you want to bring it back.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since CMake 3.29 (which is on MingW), we can omit the parameter. https://cmake.org/cmake/help/latest/manual/ctest.1.html "Otherwise, if the value is omitted, parallelism is limited by the number of processors, or 2, whichever is larger."