Pass the -DSANITIZE=<type> cmake option to libaom #2070
Conversation
This is the official way to build libaom with sanitizer support: https://aomedia.googlesource.com/aom/+/master/README.md#sanitizers
| CXXFLAGS: -fsanitize=${{ matrix.sanitizer }} | ||
| LDFLAGS: -fsanitize=${{ matrix.sanitizer }} | ||
| run: > | ||
| sed -i -e 's/cmake -G Ninja \(.*\) \.\./cmake -G Ninja \1 -DSANITIZE=${{ matrix.sanitizer }} ../g' aom.cmd |
There was a problem hiding this comment.
This line is based on line 52 below:
sed -i -e 's/meson setup \(.*\) \.\./meson setup \1 '"-Db_sanitize=${{ matrix.sanitizer }} -Db_lundef=false"' ../g' dav1d.cmd
Note that I removed the double quotes and single quotes in the middle of the sed script. They do not seem necessary for this line. Are they necessary for line 45?
There was a problem hiding this comment.
Are they necessary for line 45?
No idea, probably not. I took that from:
libavif/tests/oss-fuzz/build.sh
Line 52 in f8ad918
There was a problem hiding this comment.
Thanks for the info. I will try to remove or simplify the quotes in a separate pull request.
| CXXFLAGS: -fsanitize=${{ matrix.sanitizer }} | ||
| LDFLAGS: -fsanitize=${{ matrix.sanitizer }} | ||
| run: > | ||
| sed -i -e 's/cmake -G Ninja \(.*\) \.\./cmake -G Ninja \1 -DSANITIZE=${{ matrix.sanitizer }} ../g' aom.cmd |
There was a problem hiding this comment.
Are they necessary for line 45?
No idea, probably not. I took that from:
libavif/tests/oss-fuzz/build.sh
Line 52 in f8ad918
This is the official way to build libaom with sanitizer support: https://aomedia.googlesource.com/aom/+/master/README.md#sanitizers