Pass -f to rm in cleanup handlers

[wantehchang]

When a test fails, some of the files the cleanup handler needs to remove may not have been created, so pass -f to rm to ignore nonexistent files.

[wantehchang]

In https://github.com/AOMediaCodec/libavif/actions/runs/8351405561/job/22859682384?pr=2068, search for "No such" in the logs, you will see error messages from the rm command like the following:

+ /home/runner/work/libavif/libavif/build/avifenc -s 8 /home/runner/work/libavif/libavif/tests/data/paris_icc_exif_xmp.png --grid 7x5 -o avif_test_cmd_grid_7x5_encoded.avif
/home/runner/work/libavif/libavif/tests/test_cmd_grid.sh: line 74:  7339 Segmentation fault      (core dumped) "${AVIFENC}" -s 8 "${INPUT_PNG}" --grid 7x5 -o "${ENCODED_FILE_7x5}"
+ cleanup
+ pushd /tmp/tmp.77nsVRNFde
/tmp/tmp.77nsVRNFde /tmp/tmp.77nsVRNFde ~/work/libavif/libavif/build/tests
+ rm -- avif_test_cmd_grid_encoded.avif avif_test_cmd_grid_decoded.png avif_test_cmd_grid_2x2_encoded.avif avif_test_cmd_grid_2x2_decoded.png avif_test_cmd_grid_7x5_encoded.avif avif_test_cmd_grid_7x5_decoded.png
rm: cannot remove 'avif_test_cmd_grid_encoded.avif': No such file or directory
rm: cannot remove 'avif_test_cmd_grid_decoded.png': No such file or directory
rm: cannot remove 'avif_test_cmd_grid_7x5_encoded.avif': No such file or directory
rm: cannot remove 'avif_test_cmd_grid_7x5_decoded.png': No such file or directory

[y-guyon]

I was using that to see if some args given to rm were out-of-date, but I agree it clutters the logs (on test failure only though).

Could we have -f only on trap and not on exit success? Probably not worth the effort though. Something like:

# Assume no space in paths
FILES_TO_RM="${ENCODED_FILE}" "${DECODED_FILE}" "${ERROR_MSG}"
cleanup() {
  pushd ${TMP_DIR}
    rm -f -- ${FILES_TO_RM}
  popd
}

...
rm -- ${FILES_TO_RM} # Test should fail if a file is missing
exit 0

Feel free to merge this PR as is.

[wantehchang]

Yannis: I also noticed that rm -f prevents us from knowing the list of files to delete has become out of date.

I can abandon this pull request. Would you like to implement the approach you outlined?

[y-guyon]

I can abandon this pull request. Would you like to implement the approach you outlined?

Not now, you can merge as is, thank you.