Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci-unix-static-sanitized.yml for macos #2061

Merged
merged 1 commit into from
Mar 18, 2024
Merged

ci-unix-static-sanitized.yml for macos #2061

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .github/workflows/ci-unix-static-sanitized.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,11 @@ permissions:

jobs:
build-static-sanitized:
runs-on: ubuntu-latest
runs-on: ${{ matrix.os }}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally, we should test macOS on Arm. Not sure if there is a virtual machine for that.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not listed at https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners/about-github-hosted-runners#standard-github-hosted-runners-for-public-repositories.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

macos-14 [Beta] has the M1 CPU. I am testing it in #2064.

strategy:
fail-fast: false
matrix:
os: [ubuntu-latest, macos-latest]
sanitizer: [ undefined ] # TODO(yguyon): Add address, memory, thread

steps:
Expand Down Expand Up @@ -41,7 +42,7 @@ jobs:
if: steps.cache-ext.outputs.cache-hit != 'true'
working-directory: ./ext
run: >
sed -i 's/meson setup \(.*\) \.\./meson setup \1 '"-Db_sanitize=${{ matrix.sanitizer }} -Db_lundef=false"' ../g' ./dav1d.cmd
sed -i -e 's/meson setup \(.*\) \.\./meson setup \1 '"-Db_sanitize=${{ matrix.sanitizer }} -Db_lundef=false"' ../g' dav1d.cmd

CC=clang CXX=clang++ ./dav1d.cmd
- name: Build libyuv
Expand Down
Loading