Export EXTRA_CMAKE_FLAGS to remove the "unbound variable" error #2041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BUG=oss-fuzz:67018
y-guyon
approved these changes
Feb 26, 2024
| @@ -75,6 +75,8 @@ if [ "$FUZZING_ENGINE" == "libfuzzer" ] | |||
| then | |||
| export CXXFLAGS="${CXXFLAGS} -DFUZZTEST_COMPATIBILITY_MODE" | |||
| export EXTRA_CMAKE_FLAGS="-DAVIF_ENABLE_FUZZTEST=ON -DFUZZTEST_COMPATIBILITY_MODE=libfuzzer" | |||
| else | |||
| export EXTRA_CMAKE_FLAGS="" | |||
There was a problem hiding this comment.
No need to revert CXXFLAGS?
There was a problem hiding this comment.
nope, it is already given by the fuzzer (with all the -fsanitize ...)
There was a problem hiding this comment.
I don't think you need to export EXTRA_CMAKE_FLAGS; no subprocess depends on the value. You can just assign it to something.
If CXXFLAGS is already exported, assigning to it will update the exported value as well. Though it doesn't hurt to be explicit.
There was a problem hiding this comment.
I agree. EXTRA_CMAKE_FLAGS is only used at line 88 and just needs to be a regular shell variable rather than an environment variable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BUG=oss-fuzz:67018