Use _putenv_s() on Windows in fuzztest_helpers #2014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vrabaud
approved these changes
Feb 15, 2024
wantehchang
reviewed
Feb 15, 2024
| @@ -199,7 +199,13 @@ class Environment : public ::testing::Environment { | |||
| public: | |||
| Environment(const char* name, const char* value) | |||
| : name_(name), value_(value) {} | |||
| void SetUp() override { setenv(name_, value_, 1); } | |||
| void SetUp() override { | |||
| #ifdef WIN32 | |||
There was a problem hiding this comment.
Please change WIN32 to _WIN32 . The compiler predefined macro is named _WIN32 .
jzern
reviewed
Feb 15, 2024
| #ifdef WIN32 | ||
| _putenv_s(name_, value_); // Defined in stdlib.h. | ||
| #else | ||
| setenv(name_, value_, /*__replace=*/1); |
There was a problem hiding this comment.
The third parameter is documented as overwrite in the posix docs.
|
I addressed both review comments in #2016. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See b/308013905