Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set AVIF_ENABLE_WERROR to OFF by default, keep it to ON for the CI #1955

Merged
merged 2 commits into from
Jan 18, 2024
Merged

Set AVIF_ENABLE_WERROR to OFF by default, keep it to ON for the CI #1955

merged 2 commits into from
Jan 18, 2024

Conversation

vrabaud
Copy link
Collaborator

@vrabaud vrabaud commented Jan 18, 2024

No description provided.

@vrabaud vrabaud requested a review from jzern January 18, 2024 22:42
wantehchang
wantehchang reviewed Jan 18, 2024
View reviewed changes
Copy link
Collaborator

@wantehchang wantehchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vincent: Thank you for writing this pull request. (I was planning to write one.)

wantehchang
wantehchang approved these changes Jan 18, 2024
View reviewed changes
Copy link
Collaborator

@wantehchang wantehchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@vrabaud vrabaud merged commit 9f6e550 into AOMediaCodec:main Jan 18, 2024
@vrabaud vrabaud deleted the version_number branch January 18, 2024 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wantehchang wantehchang wantehchang approved these changes

@jzern jzern Awaiting requested review from jzern

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vrabaud @wantehchang