Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix AVM header parsing #1931

Merged
merged 1 commit into from
Jan 11, 2024
Merged

Fix AVM header parsing #1931

merged 1 commit into from
Jan 11, 2024

Conversation

vrabaud
Copy link
Collaborator

@vrabaud vrabaud commented Jan 11, 2024

No description provided.

@vrabaud vrabaud requested a review from wantehchang January 11, 2024 16:18
@vrabaud vrabaud mentioned this pull request Jan 11, 2024
Merged
wantehchang
wantehchang approved these changes Jan 11, 2024
View reviewed changes
Copy link
Collaborator

@wantehchang wantehchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I remember we only need to parse the AV1 sequence header OBU when an AVIF file doesn't have a colr box of the nclx type. If that's the case, perhaps in AVIF with AV2 we should mandate a colr box of the nclx type.

@vrabaud vrabaud merged commit b65394b into AOMediaCodec:main Jan 11, 2024
6 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wantehchang wantehchang wantehchang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vrabaud @wantehchang