Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use clang-cl to build libyuv #1930

Merged
merged 4 commits into from
Jan 12, 2024
Merged

Use clang-cl to build libyuv #1930

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e2ee23c
Use clang-cl to build libyuv
y-guyon Jan 11, 2024
b8e2c5d
Temporarily enable workflow on any push to test it
y-guyon Jan 11, 2024
becc0a2
Use PowerShell env var setting instructions
y-guyon Jan 12, 2024
0da059a
Revert trigger conditions
y-guyon Jan 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 14 additions & 6 deletions .github/workflows/ci-windows-artifacts.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,7 @@
# This workflow generates artifacts such as avifenc.exe and avifdec.exe for convenience.

name: CI Windows Artifacts
on:
push:
branches:
- main
on: [push, pull_request]

permissions:
contents: read
Expand All @@ -27,7 +24,7 @@ jobs:
uses: actions/cache@704facf57e6136b1bc63b828d79edcd491f0ee84 # v3.3.2
with:
path: ext
key: ${{ runner.os }}-${{ hashFiles('ext/*.cmd') }}-somedeps
key: ${{ runner.os }}-${{ hashFiles('ext/*.cmd') }}-somedeps2
- name: Print cmake version
run: cmake --version
- uses: ilammy/setup-nasm@13cbeb366c45c4379d3478cdcbadd8295feb5028 # v1.5.1
Expand All @@ -46,7 +43,18 @@ jobs:
- name: Build libyuv
if: steps.cache-ext.outputs.cache-hit != 'true'
working-directory: ./ext
run: ./libyuv.cmd
# Use clang-cl to build libyuv. The assembly code in libyuv is written in the
# GCC inline assembly format. Visual C++ doesn't support GCC inline assembly.
run: >
set "CC=clang-cl"
y-guyon marked this conversation as resolved.
Show resolved Hide resolved

set "CXX=clang-cl"
y-guyon marked this conversation as resolved.
Show resolved Hide resolved

./libyuv.cmd

set "CC="

set "CXX="
y-guyon marked this conversation as resolved.
Show resolved Hide resolved
- name: Build libjpeg
if: steps.cache-ext.outputs.cache-hit != 'true'
working-directory: ./ext
Expand Down
Loading