Encode an anim instead of the same frame X times #1916
Conversation
| avifPixelFormat pixel_format, | ||
| bool has_alpha, | ||
| const std::vector<uint8_t>& samples) { | ||
| std::vector<ImagePtr> frames; |
There was a problem hiding this comment.
Maybe encapsulate the function in template in the .cc (with depth as a parameter and called here with /*depth*/=8)? Just in case the function becomes more complex? Not necessary,
There was a problem hiding this comment.
I did this at first but the fuzzing engine generates garbled reproducer snippets when there are templates. Maybe this got fixed since then.
| fuzztest::Just(height), fuzztest::Just(pixel_format), | ||
| fuzztest::Just(has_alpha), | ||
| fuzztest::Arbitrary<std::vector<uint8_t>>().WithSize(GetNumSamples( | ||
| num_frames, width, height, pixel_format, has_alpha))); |
There was a problem hiding this comment.
That will force all frames to have alpha or none to have alpha. Maybe we should have a vector of bools?
Same for width and height but I actually do not know whether AVIF supports animations with frames of different size: maybe you can run this test locally to see if it passes with frames of different size?
There was a problem hiding this comment.
These proposals can be added in another PR.
| avifPixelFormat pixel_format, | ||
| bool has_alpha, | ||
| const std::vector<uint8_t>& samples) { | ||
| std::vector<ImagePtr> frames; |
There was a problem hiding this comment.
I did this at first but the fuzzing engine generates garbled reproducer snippets when there are templates. Maybe this got fixed since then.
| fuzztest::Just(height), fuzztest::Just(pixel_format), | ||
| fuzztest::Just(has_alpha), | ||
| fuzztest::Arbitrary<std::vector<uint8_t>>().WithSize(GetNumSamples( | ||
| num_frames, width, height, pixel_format, has_alpha))); |
There was a problem hiding this comment.
These proposals can be added in another PR.
|
With libaom updated to 3.8.1, we should be good to merge this right? |
|
Vincent: I didn't review this pull request. Does this pull request need a bug fix in libaom 3.8.1? |
|
I thought all internal bugs depending on this fuzzer had been fixed in 3.8.1 but there is still b/319140742. Once it is fixed, we can change this fuzzer. |
No description provided.