Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gdk-pixbuf: new quality settings #1907

Merged
merged 2 commits into from
Jan 4, 2024
Merged

Conversation

novomesk
Copy link
Contributor

@wantehchang I wanted to clean the obsolete code and to unify the code style (so it is similar to the style like other plugins' authors use).

and I wanted to do this before start deeply focusing on animation (which is the work started by @Hiers in #1325 )

Copy link
Collaborator

@wantehchang wantehchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Daniel: LGTM. I have two suggestions (one optional).

contrib/gdk-pixbuf/loader.c Show resolved Hide resolved
contrib/gdk-pixbuf/.clang-format Show resolved Hide resolved
Now we set the quality parameter directly instead of the old way,
when min_quantizer/maxQuantizer were used.
YUV444 is used for highest quality range from 90 till 100.
Copy link
Collaborator

@wantehchang wantehchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@wantehchang wantehchang merged commit 1410133 into AOMediaCodec:main Jan 4, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants