Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkgconf: Add private libraries in Requires.private for static linking #1905

Merged
merged 1 commit into from
Dec 28, 2023
Merged

pkgconf: Add private libraries in Requires.private for static linking #1905

merged 1 commit into from
Dec 28, 2023

Conversation

Biswa96
Copy link
Contributor

@Biswa96 Biswa96 commented Dec 28, 2023

@vrabaud
Copy link
Collaborator

vrabaud commented Dec 28, 2023

Thx. How do you choose the libs to link to? Why not libyuv?

@Biswa96
Copy link
Contributor Author

Biswa96 commented Dec 28, 2023

How do you choose the libs to link to?

  • For shared linking:
$ pkgconf -libs libavif
-lavif
  • For static linking:
$ pkgconf -libs -static libavif
-lavif -lsharpyuv -ldav1d -lrav1e -lkernel32 -ladvapi32 -lbcrypt -lkernel32 -lntdll -luserenv -lws2_32 -lkernel32 -lws2_32 -lkernel32 -lSvtAv1Enc -laom -lm

Why not libyuv?

libyuv does not provide any pkgconfig file. So, it can not be added in Requires.private but could be added in Libs.private. I was not sure about the later one - will be added in next commit.

@vrabaud
Copy link
Collaborator

vrabaud commented Dec 28, 2023

Thx, makes sense.

@vrabaud vrabaud merged commit 89468f8 into AOMediaCodec:main Dec 28, 2023
21 checks passed
@fdintino
Copy link
Contributor

fdintino commented Jan 5, 2024

These libraries should be omitted from Requires.private and Libs.private if they are local, since in that case they get included in the archive file. If someone else doesn't get around to addressing that I'll open a PR myself next week to fix that.

@Biswa96
Copy link
Contributor Author

Biswa96 commented Jan 5, 2024

Sure, please create a PR. I did not find the conditions for local dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants