Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avif_android jni build.gradle config ndkVersion #1751

Merged
merged 1 commit into from
Nov 13, 2023

Conversation

fdintino
Copy link
Contributor

Setting ANDROID_NDK_HOME no longer has any effect in gradle. When you run ./gradlew --info the log outputs:

C/C++: Not considering ANDROID_NDK_HOME because support was removed after deprecation period.
C/C++: Because no explicit NDK was requested, the default version [23.1.7779620] for this Android Gradle Plugin will be used
C/C++: android.ndkVersion from module build.gradle is [not set]
C/C++: android.ndkPath from module build.gradle is not set
C/C++: ndk.dir in local.properties is not set

This sets android.ndkVersion so that it matches the NDK version used in the github actions workflows.

@fdintino fdintino changed the title fix: avif_android jni build.gradle config ndkVersion and target fix: avif_android jni build.gradle config ndkVersion Nov 12, 2023
@vrabaud vrabaud requested a review from vigneshvg November 13, 2023 08:28
@fdintino fdintino force-pushed the fix/android-jni-gradle-config branch from bc261de to 817438a Compare November 13, 2023 15:17
Copy link
Collaborator

@vigneshvg vigneshvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR.

@vigneshvg vigneshvg merged commit 216ad2d into AOMediaCodec:main Nov 13, 2023
18 checks passed
@fdintino fdintino deleted the fix/android-jni-gradle-config branch November 13, 2023 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants