Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Read and write 16-bit PNG files #1252

Merged
merged 4 commits into from
Dec 16, 2022
Merged

Read and write 16-bit PNG files #1252

merged 4 commits into from
Dec 16, 2022

Conversation

y-guyon
Copy link
Collaborator

@y-guyon y-guyon commented Dec 14, 2022 •
edited
Loading

Allow and check RGB-YUV conversion for 16-bit samples.

Note: This PR is necessary for #1215.

@y-guyon
Read and write 16-bit PNG files
51553e0 
Allow and check RGB-YUV conversion for 16-bit samples.
@jzern
Copy link
Collaborator

jzern commented Dec 14, 2022

Maybe a changelog entry?

wantehchang
wantehchang approved these changes Dec 15, 2022
View reviewed changes
Copy link
Collaborator

@wantehchang wantehchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I suggest two changes.

CHANGELOG.md Outdated Show resolved Hide resolved
tests/CMakeLists.txt Outdated Show resolved Hide resolved
@y-guyon y-guyon merged commit 93035c1 into AOMediaCodec:main Dec 16, 2022
@y-guyon y-guyon deleted the png_16b branch December 16, 2022 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wantehchang wantehchang wantehchang approved these changes

@jzern jzern jzern approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@y-guyon @jzern @wantehchang