-
Notifications
You must be signed in to change notification settings - Fork 208
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Handle size 0 in avifROStreamReadBoxHeaderPartial
Move ReadFile() from avifincrtest to aviftest_helpers. Delete unused GetWhiteSinglePixelAvif(). Add avifsize0test.
- Loading branch information
Showing
11 changed files
with
182 additions
and
69 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,107 @@ | ||
| // Copyright 2024 Google LLC | ||
| // SPDX-License-Identifier: BSD-2-Clause | ||
|
|
||
| #include <algorithm> | ||
| #include <iostream> | ||
| #include <string> | ||
|
|
||
| #include "avif/avif.h" | ||
| #include "aviftest_helpers.h" | ||
| #include "gtest/gtest.h" | ||
|
|
||
| namespace avif { | ||
| namespace { | ||
|
|
||
| // Used to pass the data folder path to the GoogleTest suites. | ||
| const char* data_path = nullptr; | ||
|
|
||
| //------------------------------------------------------------------------------ | ||
|
|
||
| TEST(AvifDecodeTest, SingleWhitePixel) { | ||
| const char* file_name = "white_1x1.avif"; | ||
| DecoderPtr decoder(avifDecoderCreate()); | ||
| ASSERT_NE(decoder, nullptr); | ||
| ASSERT_EQ(avifDecoderSetIOFile(decoder.get(), | ||
| (std::string(data_path) + file_name).c_str()), | ||
| AVIF_RESULT_OK); | ||
| ASSERT_EQ(avifDecoderParse(decoder.get()), AVIF_RESULT_OK); | ||
| if (testutil::Av1DecoderAvailable()) { | ||
| EXPECT_EQ(avifDecoderNextImage(decoder.get()), AVIF_RESULT_OK); | ||
| } | ||
| } | ||
|
|
||
| TEST(AvifDecodeTest, MdatSize0) { | ||
| testutil::AvifRwData avif = | ||
| testutil::ReadFile(std::string(data_path) + "white_1x1.avif"); | ||
| // Edit the file to simulate an 'mdat' box with size 0 (meaning ending at EOF) | ||
| const uint8_t* kMdat = reinterpret_cast<const uint8_t*>("mdat"); | ||
| uint8_t* mdat_position = | ||
| std::search(avif.data, avif.data + avif.size, kMdat, kMdat + 4); | ||
| ASSERT_NE(mdat_position, avif.data + avif.size); | ||
| mdat_position[-1] = '\0'; | ||
|
|
||
| DecoderPtr decoder(avifDecoderCreate()); | ||
| ASSERT_NE(decoder, nullptr); | ||
| ASSERT_EQ(avifDecoderSetIOMemory(decoder.get(), avif.data, avif.size), | ||
| AVIF_RESULT_OK); | ||
| ASSERT_EQ(avifDecoderParse(decoder.get()), AVIF_RESULT_OK); | ||
| if (testutil::Av1DecoderAvailable()) { | ||
| EXPECT_EQ(avifDecoderNextImage(decoder.get()), AVIF_RESULT_OK); | ||
| } | ||
| } | ||
|
|
||
| TEST(AvifDecodeTest, MetaSize0) { | ||
| testutil::AvifRwData avif = | ||
| testutil::ReadFile(std::string(data_path) + "white_1x1.avif"); | ||
| // Edit the file to simulate a 'meta' box with size 0 (invalid). | ||
| const uint8_t* kMeta = reinterpret_cast<const uint8_t*>("meta"); | ||
| uint8_t* meta_position = | ||
| std::search(avif.data, avif.data + avif.size, kMeta, kMeta + 4); | ||
| ASSERT_NE(meta_position, avif.data + avif.size); | ||
| meta_position[-1] = '\0'; | ||
|
|
||
| DecoderPtr decoder(avifDecoderCreate()); | ||
| ASSERT_NE(decoder, nullptr); | ||
| ASSERT_EQ(avifDecoderSetIOMemory(decoder.get(), avif.data, avif.size), | ||
| AVIF_RESULT_OK); | ||
|
|
||
| // This should fail because the meta box contains the mdat box. | ||
| // However, the section 8.11.3.1 of ISO/IEC 14496-12 does not explicitly | ||
| // require the coded image item extents to be read from the MediaDataBox if | ||
| // the construction_method is 0. | ||
| // Maybe another section or specification enforces that. | ||
| ASSERT_EQ(avifDecoderParse(decoder.get()), AVIF_RESULT_OK); | ||
| if (testutil::Av1DecoderAvailable()) { | ||
| EXPECT_EQ(avifDecoderNextImage(decoder.get()), AVIF_RESULT_OK); | ||
| } | ||
| } | ||
|
|
||
| TEST(AvifDecodeTest, FtypSize0) { | ||
| testutil::AvifRwData avif = | ||
| testutil::ReadFile(std::string(data_path) + "white_1x1.avif"); | ||
| // Edit the file to simulate a 'ftyp' box with size 0 (invalid). | ||
| avif.data[3] = '\0'; | ||
|
|
||
| DecoderPtr decoder(avifDecoderCreate()); | ||
| ASSERT_NE(decoder, nullptr); | ||
| ASSERT_EQ(avifDecoderSetIOMemory(decoder.get(), avif.data, avif.size), | ||
| AVIF_RESULT_OK); | ||
| ASSERT_EQ(avifDecoderParse(decoder.get()), AVIF_RESULT_BMFF_PARSE_FAILED); | ||
| } | ||
|
|
||
| //------------------------------------------------------------------------------ | ||
|
|
||
| } // namespace | ||
| } // namespace avif | ||
|
|
||
| int main(int argc, char** argv) { | ||
| ::testing::InitGoogleTest(&argc, argv); | ||
| if (argc != 2) { | ||
| std::cerr << "There must be exactly one argument containing the path to " | ||
| "the test data folder" | ||
| << std::endl; | ||
| return 1; | ||
| } | ||
| avif::data_path = argv[1]; | ||
| return RUN_ALL_TESTS(); | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters