Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding initial version of bikeshed file #46

Merged
merged 10 commits into from
Jan 9, 2025
Merged

adding initial version of bikeshed file #46

merged 10 commits into from
Jan 9, 2025

Conversation

cconcolato
Copy link
Collaborator

No description provided.

@cconcolato cconcolato marked this pull request as draft March 11, 2024 20:42
@cconcolato
Copy link
Collaborator Author

Need to:

  • add asserts

@cconcolato
Copy link
Collaborator Author

@podborski can you check why the build is failing?

@podborski
Copy link
Collaborator

@podborski can you check why the build is failing?

@cconcolato done

@podborski
Copy link
Collaborator

@cconcolato how can we set up this spec preview feature?

@cconcolato
Copy link
Collaborator Author

@podborski
Copy link
Collaborator

We need to add https://github.com/AOMediaCodec/av1-isobmff/blob/main/.pr-preview.json

I guess this needs to be in the main branch too?

@cconcolato
Copy link
Collaborator Author

We need to add https://github.com/AOMediaCodec/av1-isobmff/blob/main/.pr-preview.json

I guess this needs to be in the main branch too?

Yes. There is also an application to install but for some reason I cannot do it in this repository...

@cconcolato
Copy link
Collaborator Author

@cconcolato cconcolato marked this pull request as ready for review January 8, 2025 17:11
@cconcolato
Copy link
Collaborator Author

@podborski Any objections to merging this PR?

@podborski
Copy link
Collaborator

No objections.

@podborski podborski merged commit 53cbea3 into master Jan 9, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants