Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add missing close assert #200

Merged
merged 1 commit into from
Mar 5, 2024
Merged

add missing close assert #200

merged 1 commit into from
Mar 5, 2024

Conversation

podborski
Copy link
Collaborator

@podborski podborski commented Mar 5, 2024 •
edited by pr-preview bot
Loading

@podborski podborski mentioned this pull request Mar 5, 2024
Merged
@cconcolato cconcolato merged commit cbbcaa8 into main Mar 5, 2024
1 check passed
@cconcolato cconcolato deleted the assert_fix branch March 5, 2024 14:39
wantehchang
wantehchang reviewed Mar 5, 2024
View reviewed changes
Copy link
Collaborator

@wantehchang wantehchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wantehchang wantehchang wantehchang left review comments

@cconcolato cconcolato cconcolato approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@podborski @cconcolato @wantehchang