-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a scrapper for Yahoo Finance Data in the YahooFinanceProcessor class #1305
Added a scrapper for Yahoo Finance Data in the YahooFinanceProcessor class #1305
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
for more information, see https://pre-commit.ci
@BruceYanghy I opened an issue related to the pre-commit fails, indeed, fails appear even on a virgin installation of FinRL (without having modified the code at all), I think this is a big issue since no PR at all can pass the test |
for more information, see https://pre-commit.ci
thanks . |
The code works well yes, I only have an issue to commit it (because of pre-commit fails as you can notice), I tried to modify the code directly on github and created another PR but it fails the same... I don't know what to do. |
now that this code works well, I will merge it. |
Hello,
The YahooDownloader class is limited by the max number of request per hour (2000) which prevents one to use the current code since it's trying to retrieve data from '2010-01-01' to '2023-03-01' which is way more than 2k requests.
I built a function scrap_data in YahooFinanceProcessor class to retrieve the same data as the YahooDownloader but by scrapping the website with Selenium.
I tested the code and it's working as you can see on the screenshot below:
In addition, one should install Google Chrome using the following commands:
the above command may produce errors related to missing deps so do: