Isolate storage library #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hugoib pls check the protection on this repo |
|
Added branch protection, after we set the structure of how many libraries will live in this repo, we will implement proper CI checks: |
hugoib
reviewed
Sep 23, 2024
hugoib
reviewed
Sep 23, 2024
|
I reviewed, it looks good, tests are passing after adding typescript to the package.json After we approve this: Please adapt to that structure and I will review again before merging |
…organization and consistency, added TypeScript support and improved package.json structure
|
I reviewed again, looks good! Waiting for the pipeline to pass and then I will approve it. |
|
First merge this: #7 |
hugoib
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor storage logic into a standalone library in a new repository for reusability