Feature/validate pin for balance #89
Conversation
|
@stephane-segning requesting review for validation of user's pin for balance display |
|
@stephane-segning have removed unnecessary files and the requesting for review. |
There was a problem hiding this comment.
Good work @Christiantyemele! Now, please redo this using good Java Patterns.
|
good work @Koufan-De-King! we have to make it now in good java design patterns with @forkimenjeckayang's help |
These changes doesn't belongs to this ticket. Please @Christiantyemele remove them. |
docs/ValidatePInDisplayBalance.md
Outdated
| + validatePIN(PhoneNumber,PIN) | ||
| } | ||
| class UserRepository { | ||
| - PIN |
There was a problem hiding this comment.
I don't agree having the PIN as an attribute. It's not something that belongs to a Repository. It belongs to a user.
docs/ValidatePInDisplayBalance.md
Outdated
| } | ||
| class UserRepository { | ||
| - PIN | ||
| + getPIN(PhoneNumber) |
There was a problem hiding this comment.
Having a method getPIN is a security issue, because someone, provided he entered the system, can read user's PINs.
There was a problem hiding this comment.
You can request @Bansikah's help to better understand how you can hide the PIN and still use it to validate the password.
There was a problem hiding this comment.
You can request @Bansikah's help to better understand how you can hide the PIN and still use it to validate the password.
noted @stephane-segning
Koufan-De-King
force-pushed
the
feature/Validate-Pin-For-Balance
branch
from
240ee71
to
31d7543
Compare
No description provided.