feature: useStorage hook to persist data on frontend #83
Conversation
|
hello sir @stephane-segning please waiting for review on this PR |
|
hello sir @stephane-segning so we will have a StorageContext.ts? inside the {root}/src/contexts folder |
…plement useStorage hook
|
hello sir @stephane-segning Added StorageContext global context for interacting with localStorage please review ths PR |
…lement useStorage hook
|
hello sir @stephane-segning please review this pull request |
There was a problem hiding this comment.
Create and managing state management inside of an app is always tricky. Working with react context is no exception. But we'll handle this. Take your time to review these points @AssahBismarkabah
|
hello sir @stephane-segning please waiting for your review on this PR |
|
hello sir @stephane-segning please review this changes |
|
hello sir @stephane-segning waiting for your review |
There was a problem hiding this comment.
Nice work @AssahBismarkabah @Christiantyemele ! Just these few points now
| }, | ||
| removeItem: async (key) => clearItem(key), | ||
| clear: async () => { | ||
| localStorage.clear(); |
There was a problem hiding this comment.
Remove this line too
| if (storedValue !== undefined) { | ||
| setItem(key, storedValue); | ||
| } |
There was a problem hiding this comment.
Here you can remove the if condition there
There was a problem hiding this comment.
ok sir @stephane-segning
There was a problem hiding this comment.
You didn't removed this if
| if (storedValue !== undefined) { | ||
| setItem(key, storedValue); | ||
| } |
There was a problem hiding this comment.
You didn't removed this if
|
hello sir @stephane-segning I have added the docs for the indexDB storage and requesting for review before further do |
|
@AssahBismarkabah and @Motouom request and @stephane-segning please requesting for review on this PR |
| const [storedValue, setStoredValue] = useState<T | undefined>(() => { | ||
| return item[key] ?? initialValue; | ||
| }); |
There was a problem hiding this comment.
Remove this and use item[key] directly instead of 'storedValue'
|
@AssahBismarkabah @Christiantyemele please consider these changes that @stephane-segning asked |
added useStorage to persist data on the frontend