Feat/63 implement health endpoint #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@stephane-segning please review the last point under ticket Implement health Endpoint for Health Check in PowerPay Server #63 implemented by @chendiblessing |
stephane-segning
requested changes
Mar 7, 2024
...kend/src/main/java/com/adorsys/gis/powerpay/powerpaybackend/controller/HealthController.java
Outdated
Show resolved
Hide resolved
…-victor/e2e-banking-app into feat/63-implement-health-endpoint
|
@stephane-segning i have made the changes you requested |
stephane-segning
requested changes
Mar 9, 2024
...kend/src/main/java/com/adorsys/gis/powerpay/powerpaybackend/controller/HealthController.java
Outdated
Show resolved
Hide resolved
|
Prof @stephane-segning changes done |
Fix failing test
stephane-segning
requested changes
Mar 9, 2024
power-pay-backend/pom.xml
Outdated
| @@ -27,10 +27,10 @@ | |||
| <groupId>org.springframework.boot</groupId> | |||
| <artifactId>spring-boot-starter-data-jpa</artifactId> | |||
| </dependency> | |||
| <dependency> | |||
| <!-- <dependency> | |||
There was a problem hiding this comment.
What is this change?
| @SpringBootTest | ||
| @AutoConfigureMockMvc | ||
| @ContextConfiguration(classes = { PowerPayBackendApplication.class }) | ||
| public class PowerPayBackendHealthTest { |
There was a problem hiding this comment.
This is testing the best case. You should also test the case the server is not sending 200 ok
|
hello prof @stephane-segning i did the last changes you demanded please you can now review |
|
@stephane-segning everything well done |
stephane-segning
approved these changes
Mar 19, 2024
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added the unit test for the health endpoint