-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature basic classes for each service #64 #71
Merged
stephane-segning
merged 6 commits into
ADORSYS-GIS:main
from
Motouom:feature-basic-classes-for-each-service-#64
Mar 7, 2024
Merged
Feature basic classes for each service #64 #71
stephane-segning
merged 6 commits into
ADORSYS-GIS:main
from
Motouom:feature-basic-classes-for-each-service-#64
Mar 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hello sir, good morning,please waiting for review for this PR |
stephane-segning
requested changes
Mar 7, 2024
...ackend/src/main/java/com/adorsys/gis/powerpay/powerpaybackend/services/CheckBalanceImpl.java
Show resolved
Hide resolved
...y-backend/src/main/java/com/adorsys/gis/powerpay/powerpaybackend/services/SendMoneyImpl.java
Show resolved
Hide resolved
…of github.com:Motouom/e2e-banking-app into feature-basic-classes-for-each-service-ADORSYS-GIS#64
Good morning Sir @stephane-segning , Changes made as requested |
stephane-segning
approved these changes
Mar 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome
Christiantyemele
pushed a commit
to Christiantyemele/forked-e2e-banking-app
that referenced
this pull request
Apr 9, 2024
* feat(backend): Implemented empty interfaces for sendMoney & checkBalance features. * feat: added annotation ensure classes are recognized as Spring Beans * Added(SendMoneyImpl.java):Basic skeleton for implementation of the SendMoney Interface * fix: removed annotation -> component * Modified(SendMoneyImpl.java):Removed the @component annotation --------- Co-authored-by: AssahBismarkabah <[email protected]> Co-authored-by: forkimenjeckayang <[email protected]>
Christiantyemele
pushed a commit
to Christiantyemele/forked-e2e-banking-app
that referenced
this pull request
Apr 9, 2024
* feat(backend): Implemented empty interfaces for sendMoney & checkBalance features. * feat: added annotation ensure classes are recognized as Spring Beans * Added(SendMoneyImpl.java):Basic skeleton for implementation of the SendMoney Interface * fix: removed annotation -> component * Modified(SendMoneyImpl.java):Removed the @component annotation --------- Co-authored-by: AssahBismarkabah <[email protected]> Co-authored-by: forkimenjeckayang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added interface and implementation for for the services. review required @stephane-segning