fea/css-tailwind #69

Ogenbertrand · 2024-03-06T13:46:56Z

I created a md file for the tailwind css system design

Ogenbertrand · 2024-03-06T13:50:03Z

@stephane-segning pr for ticket Setup css design system #49

stephane-segning

Good work!

Ogenbertrand · 2024-03-07T10:57:38Z

@stephane-segning
generate a tailwind.config.js file in the power-pay-frontend/

stephane-segning

Good work overall @Ogenbertrand! Please address these points so that we can go forward

power-pay-frontend/src/App.css

power-pay-frontend/tailwind.config.js

Ogenbertrand · 2024-03-07T13:04:52Z

Hello @stephane-segning i just made the changes in the App.css and tailwind.config file. I also added vite in our project to help enhance development experience when working with tailwind.
add (tsx,ts,js) extensions in the tailwind config file
delete content (config directive) from the src/App.css

Ogenbertrand · 2024-03-08T07:45:32Z

@stephane-segning
i create a new tailwind.config.ts
create a new config file (/power-pay-frontend/tailwind.config.ts)

stephane-segning

You created a new frontend project e2e-banking-app-tailwind, while the question was for you to add tailwindcss to the already existing project. Remove the e2e-banking-app-tailwind folder first. Then proceed on the ticket.

Ogenbertrand · 2024-03-08T08:46:21Z

@stephane-segning
I just deleted the e2e-banking-app-tailwind/ from our project dir and i a added tailwindcss in our project.
dicard the (e2e-banking-app-tailwind/) from the project working dir

power-pay-frontend/src/App.css

power-pay-frontend/package.json

Ogenbertrand · 2024-03-11T13:12:46Z

@stephane-segning i added a config file for postcss
Add a config file for potscss in power-pay-frontend/

Ogenbertrand · 2024-03-12T07:31:06Z

@stephane-segning
creat a new package.lock.json file in the power-pay-frontend/

…/package.json

Ogenbertrand · 2024-03-12T07:55:05Z

@stephane-segning
define a build script in the script section of the power-pay-frontend…

power-pay-frontend/package.json

Ogenbertrand · 2024-03-12T10:38:10Z

@stephane-segning
edit the postcss.config.js to postcss.config.cjs file

power-pay-frontend/package.json

Ogenbertrand · 2024-03-12T10:53:38Z

@stephane-segning
add a new version of vite in package.json file

stephane-segning · 2024-03-12T11:12:42Z

power-pay-frontend/package.json

  "version": "0.0.0",
  "type": "module",
  "scripts": {
    "predeploy": "npm run build",
    "deploy": "gh-pages -d build",
    "build-for-gh": "vite build --base=/e2e-banking-app",
+    "test": "echo \"Error: no test specified\" && exit 1",
+    "start": "react-scripts start",


Why react-scripts, while we're using vite ? Read again about react with vite here.

stephane-segning · 2024-03-12T11:12:57Z

power-pay-frontend/package.json

@@ -1,13 +1,15 @@
 {
  "name": "power-pay-frontend",
  "private": true,
-  "homepage": "https://ADORSYS-GIS.github.io/e2e-banking-app",
+  "homepage": "https://adorsys-gis.github.io/e2e-banking-app",


Why changing this?

Ogenbertrand · 2024-03-12T12:34:38Z

@stephane-segning
the start script is set vite in package.json file

Ogenbertrand · 2024-03-14T15:01:39Z

@stephane-segning
I just applied the changes in the package.json file
Add a sass package in the package.json file.

Ogenbertrand · 2024-03-15T03:24:34Z

@stephane-segning
Update script: Remove placeholder 'test' command

stephane-segning

Good work @Ogenbertrand !

Add a (css-tailwind.md)file in the docs/

8f59506

Ogenbertrand changed the title ~~Add a (css-tailwind.md)file in the docs/~~ CSS System Design Mar 6, 2024

Ogenbertrand changed the title ~~CSS System Design~~ fea/css-tailwind Mar 6, 2024

stephane-segning approved these changes Mar 6, 2024

View reviewed changes

generate a tailwind.config.js file in the power-pay-frontend/

151c470

stephane-segning requested changes Mar 7, 2024

View reviewed changes

power-pay-frontend/src/App.css Outdated Show resolved Hide resolved

power-pay-frontend/tailwind.config.js Outdated Show resolved Hide resolved

Ogenbertrand added 2 commits March 7, 2024 13:38

add (tsx,ts,js) extensions in the tailwind config file

45119de

delete content (config directive) from the src/App.css

27a2ba1

create a new config file (/power-pay-frontend/tailwind.config.ts)

6971300

stephane-segning requested changes Mar 8, 2024

View reviewed changes

dicard the (e2e-banking-app-tailwind/) from the project working dir

14cb7ff

stephane-segning requested changes Mar 8, 2024

View reviewed changes

power-pay-frontend/src/App.css Outdated Show resolved Hide resolved

power-pay-frontend/package.json Show resolved Hide resolved

Ogenbertrand and others added 2 commits March 11, 2024 14:08

Add a config file for potscss in power-pay-frontend/

43d3055

Merge branch 'main' into fea/css-tailwind

ba4c9ba

creat a new package.lock.json file in the power-pay-frontend/

419441c

define a build script in the script section of the power-pay-frontend…

2d423aa

…/package.json

stephane-segning requested changes Mar 12, 2024

View reviewed changes

power-pay-frontend/package.json Show resolved Hide resolved

Ogenbertrand requested a review from stephane-segning March 12, 2024 09:09

edit the postcss.config.js to postcss.config.cjs file

0c7d0ec

stephane-segning requested changes Mar 12, 2024

View reviewed changes

power-pay-frontend/package.json Outdated Show resolved Hide resolved

power-pay-frontend/package.json Outdated Show resolved Hide resolved

stephane-segning requested changes Mar 12, 2024

View reviewed changes

the start script is set vite in package.json file

6c0e8a2

Add a sass package in the package.json file.

8340b7a

Update script: Remove placeholder 'test' command

fc1784b

stephane-segning approved these changes Mar 19, 2024

View reviewed changes

stephane-segning merged commit 68087a2 into ADORSYS-GIS:main Mar 19, 2024
3 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fea/css-tailwind #69

fea/css-tailwind #69

Ogenbertrand commented Mar 6, 2024

Ogenbertrand commented Mar 6, 2024 •

edited

Loading

stephane-segning left a comment

Ogenbertrand commented Mar 7, 2024 •

edited

Loading

stephane-segning left a comment

Ogenbertrand commented Mar 7, 2024 •

edited

Loading

Ogenbertrand commented Mar 8, 2024 •

edited

Loading

stephane-segning left a comment

Ogenbertrand commented Mar 8, 2024 •

edited

Loading

Ogenbertrand commented Mar 11, 2024

Ogenbertrand commented Mar 12, 2024

Ogenbertrand commented Mar 12, 2024

Ogenbertrand commented Mar 12, 2024

Ogenbertrand commented Mar 12, 2024

stephane-segning Mar 12, 2024

stephane-segning Mar 12, 2024

Ogenbertrand commented Mar 12, 2024

Ogenbertrand commented Mar 14, 2024

Ogenbertrand commented Mar 15, 2024 •

edited

Loading

stephane-segning left a comment

fea/css-tailwind #69

fea/css-tailwind #69

Conversation

Ogenbertrand commented Mar 6, 2024

Ogenbertrand commented Mar 6, 2024 • edited Loading

stephane-segning left a comment

Choose a reason for hiding this comment

Ogenbertrand commented Mar 7, 2024 • edited Loading

stephane-segning left a comment

Choose a reason for hiding this comment

Ogenbertrand commented Mar 7, 2024 • edited Loading

Ogenbertrand commented Mar 8, 2024 • edited Loading

stephane-segning left a comment

Choose a reason for hiding this comment

Ogenbertrand commented Mar 8, 2024 • edited Loading

Ogenbertrand commented Mar 11, 2024

Ogenbertrand commented Mar 12, 2024

Ogenbertrand commented Mar 12, 2024

Ogenbertrand commented Mar 12, 2024

Ogenbertrand commented Mar 12, 2024

stephane-segning Mar 12, 2024

Choose a reason for hiding this comment

stephane-segning Mar 12, 2024

Choose a reason for hiding this comment

Ogenbertrand commented Mar 12, 2024

Ogenbertrand commented Mar 14, 2024

Ogenbertrand commented Mar 15, 2024 • edited Loading

stephane-segning left a comment

Choose a reason for hiding this comment

Ogenbertrand commented Mar 6, 2024 •

edited

Loading

Ogenbertrand commented Mar 7, 2024 •

edited

Loading

Ogenbertrand commented Mar 7, 2024 •

edited

Loading

Ogenbertrand commented Mar 8, 2024 •

edited

Loading

Ogenbertrand commented Mar 8, 2024 •

edited

Loading

Ogenbertrand commented Mar 15, 2024 •

edited

Loading