Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linking pages of the front end #143

Merged
merged 5 commits into from
Jun 13, 2024
Merged

Linking pages of the front end #143

merged 5 commits into from
Jun 13, 2024

Conversation

Motouom
Copy link
Collaborator

@Motouom Motouom commented Jun 13, 2024 •
edited
Loading

@Arielpetit @Ngha-Boris @Koufan-De-King please review this PR

image image image image image image image image image image

@Motouom Motouom self-assigned this Jun 13, 2024
Koufan-De-King
Koufan-De-King approved these changes Jun 13, 2024
View reviewed changes
Copy link
Collaborator

@Koufan-De-King Koufan-De-King left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, @Motouom ! The routing configuration is well done.
The alignment of the components such as the buttons and input fields should be worked on next.

@Motouom
Copy link
Collaborator Author

Motouom commented Jun 13, 2024

Great, @Motouom ! The routing configuration is well done. The alignment of the components such as the buttons and input fields should be worked on next.

Okay @Koufan-De-King

@Motouom
Copy link
Collaborator Author

Motouom commented Jun 13, 2024

Great, @Motouom ! The routing configuration is well done. The alignment of the components such as the buttons and input fields should be worked on next.

Okay @Koufan-De-King

Done @Koufan-De-King please can you review it again.

Calebasah
Calebasah approved these changes Jun 13, 2024
View reviewed changes
Copy link
Collaborator

@Calebasah Calebasah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!!, Mr @Motouom

@Koufan-De-King
Copy link
Collaborator

Great, @Motouom ! The routing configuration is well done. The alignment of the components such as the buttons and input fields should be worked on next.

Okay @Koufan-De-King

Done @Koufan-De-King please can you review it again.

Perfect @Motouom

Arielpetit

This comment was marked as outdated.

Sign in to view

@Motouom
Copy link
Collaborator Author

Motouom commented Jun 13, 2024

please @Motouom why is this file power-pay-frontend/src/components/scan_rq.tsx there? we used the useNavigate already and all the routs are in the App.tsx

This file is the file for the scanner of the QR Code so it is essential. @Arielpetit

@Arielpetit Arielpetit self-requested a review June 13, 2024 13:16
@Arielpetit Arielpetit merged commit 6d1144f into ADORSYS-GIS:main Jun 13, 2024
3 checks passed
Ngha-Boris
Ngha-Boris reviewed Jun 14, 2024
View reviewed changes
Copy link
Collaborator

@Ngha-Boris Ngha-Boris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ngha-Boris Ngha-Boris Ngha-Boris left review comments

@Arielpetit Arielpetit Arielpetit approved these changes

@Koufan-De-King Koufan-De-King Koufan-De-King approved these changes

@Calebasah Calebasah Calebasah approved these changes

Assignees

@Motouom Motouom

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Motouom @Koufan-De-King @Arielpetit @Ngha-Boris @Calebasah