Money transfer validation #135
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ogenbertrand
requested review from
stephane-segning,
ArmandMeppa,
Arielpetit and
bengo237
and removed request for
ArmandMeppa
|
@stephane-segning |
|
What is the ticket you're working on? |
stephane-segning
requested changes
Apr 19, 2024
.../main/java/com/adorsys/gis/powerpay/powerpaybackend/errorhandling/TransactionRepository.java
Outdated
Show resolved
Hide resolved
...pay-backend/src/main/java/com/adorsys/gis/powerpay/powerpaybackend/services/Transaction.java
Outdated
Show resolved
Hide resolved
...nd/src/main/java/com/adorsys/gis/powerpay/powerpaybackend/services/MoneyTransferService.java
Show resolved
Hide resolved
Ogenbertrand
requested review from
bryandino673
and removed request for
bengo237
Ogenbertrand
force-pushed
the
money-transfer-validation
branch
2 times, most recently
from
f37562e
to
cb8fe29
Compare
…lement jpa in the MoneyTranferRepo
|
Hello @stephane-segning, i implemented all the changes you requested for this PR. |
stephane-segning
requested changes
Jun 19, 2024
...r-pay-backend/src/main/java/com/adorsys/gis/powerpay/powerpaybackend/domain/Transaction.java
Outdated
Show resolved
Hide resolved
...nd/src/main/java/com/adorsys/gis/powerpay/powerpaybackend/services/MoneyTransferService.java
Outdated
Show resolved
Hide resolved
...nd/src/main/java/com/adorsys/gis/powerpay/powerpaybackend/services/MoneyTransferService.java
Outdated
Show resolved
Hide resolved
...kend/src/main/java/com/adorsys/gis/powerpay/powerpaybackend/services/TransactionService.java
Show resolved
Hide resolved
|
Hello @stephane-segning fix: Refactor MoneyTransferService to improve validation and error ha… |
stephane-segning
requested changes
Jun 24, 2024
...kend/src/main/java/com/adorsys/gis/powerpay/powerpaybackend/services/TransactionService.java
Outdated
Show resolved
Hide resolved
...main/java/com/adorsys/gis/powerpay/powerpaybackend/repository/MoneyTransferValidateRepo.java
Show resolved
Hide resolved
...main/java/com/adorsys/gis/powerpay/powerpaybackend/repository/MoneyTransferValidateRepo.java
Outdated
Show resolved
Hide resolved
|
Hello @stephane-segning corrected the changes requested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I Implemented the send money validation