Implement the frontend page for recipient's data input using ppa #26 #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ent the frontend page for recipient's data input manually using-PPA-
Ngha-Boris
requested review from
stephane-segning,
AssahBismarkabah,
Koufan-De-King and
Motouom
Motouom
requested changes
Apr 12, 2024
|
Please also make sure that your front-end matches with the mock-up that was provided. |
Motouom
reviewed
Apr 15, 2024
There was a problem hiding this comment.
please also send the output of the front-end pages so that we see what it looks like
for
- the input option page
- the qr-scan page
- input manually page
@Ngha-Boris @Blindspot22 @Tekum-Emmanuella
ok on it |
…ents of the page to the center
…ents of the page to the center
…using-PPA-ADORSYS-GIS#26' of github.com:Tekum-Emmanuella/e2e-banking-app into Implement-the-frontend-page-for-recipient's-data-input-using-PPA-ADORSYS-GIS#26
stephane-segning
requested changes
Apr 17, 2024
|
I have updated the userinfo for manual input and made it responsive. |
|
the userinfo for manual input has been made responsive sir
…On Mon, Apr 15, 2024 at 1:26 PM Motouom Victoire ***@***.***> wrote:
image.png (view on web)
<https://github.com/ADORSYS-GIS/e2e-banking-app/assets/149515567/3f8d3d5b-79b1-45dc-8714-a407a2541ada>
the QR-scan has to be in a new page and on on the same page as the input
option
—
Reply to this email directly, view it on GitHub
<#131 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BDYXUCFKK23JBD3N5DH2C63Y5PBQJAVCNFSM6AAAAABGEJDGE6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANJWG4ZTCOBTGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@Tekum-Emmanuella Please learn to always tag people when replying their message it alerts them more precisely |
…recipient's-data-input-using-PPA-ADORSYS-GIS#26
…mentoption.tsx for beter comprehension.
…using-PPA-ADORSYS-GIS#26' of github.com:Tekum-Emmanuella/e2e-banking-app into Implement-the-frontend-page-for-recipient's-data-input-using-PPA-ADORSYS-GIS#26
…data-input-using-PPA-ADORSYS-GIS#26
done |
stephane-segning
requested changes
Apr 23, 2024
stephane-segning
requested changes
May 6, 2024
Required changes have been done in other to format the route.tst to replace userInfo with RecipientInfo.
|
Good morning [email protected]. please all the above changes you requested for have been resolved. |
stephane-segning
approved these changes
May 7, 2024
stephane-segning
requested changes
May 7, 2024
Motouom
approved these changes
Jun 11, 2024
Arielpetit
approved these changes
Jun 11, 2024
stephane-segning
requested changes
Jun 11, 2024
stephane-segning
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Payment Options
QR-scan
Form