-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the OKPage.tsx file. #117
Conversation
@stephane-segning |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ticket's name is fea/service worker
, but where is it?
Hello sir the fea/service worker branch was merged in the main branch already, after the the merging was done it happened that one test was failing from the main branch which is the "build test". So what i did was i navigated to the main branch and started debugging from there which i ended up fixing the fault and i created a new PR. |
After creating the new PR from the main branch it happened that my commits weren't verified so my work couldn't be merged what i did is i undo all the commits from the PR closed it and created another PR which is this one |
@Ogenbertrand tag @stephane-segning when you are writing a comment if not, he won't see it |
It's a nice story but not interesting @Ogenbertrand. This PR is created under a specific name. But that name does not match the implementation. Try fixing that |
Okay sir @stephane-segning. I just fixed it |
Then what are you updating here? |
@stephane-segning |
No description provided.