Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the OKPage.tsx file. #117

Merged
merged 2 commits into from
Apr 12, 2024
Merged

Conversation

Ogenbertrand
Copy link
Collaborator

No description provided.

@Ogenbertrand
Copy link
Collaborator Author

@stephane-segning
Please review my PR.
fix the build error in the main

Copy link
Contributor

@stephane-segning stephane-segning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ticket's name is fea/service worker, but where is it?

@Ogenbertrand
Copy link
Collaborator Author

Ogenbertrand commented Apr 8, 2024

@stephane-segning

The ticket's name is fea/service worker, but where is it?

Hello sir the fea/service worker branch was merged in the main branch already, after the the merging was done it happened that one test was failing from the main branch which is the "build test". So what i did was i navigated to the main branch and started debugging from there which i ended up fixing the fault and i created a new PR.

@Ogenbertrand
Copy link
Collaborator Author

Ogenbertrand commented Apr 8, 2024

@stephane-segning

The ticket's name is fea/service worker, but where is it?

Hello sir the fea/service worker branch was merged in the main branch already, after the the merging was done it happened that one test was failing from the main branch which is the "build test". So what i did was i navigated to the main branch and started debugging from there which i ended up fixing the fault and i created a new PR.

After creating the new PR from the main branch it happened that my commits weren't verified so my work couldn't be merged what i did is i undo all the commits from the PR closed it and created another PR which is this one

@Motouom
Copy link
Collaborator

Motouom commented Apr 8, 2024

The ticket's name is fea/service worker, but where is it?

Hello sir the fea/service worker branch was merged in the main branch already, after the the merging was done it happened that one test was failing from the main branch which is the "build test". So what i did was i navigated to the main branch and started debugging from there which i ended up fixing the fault and i created a new PR.

After creating the new PR from the main branch it happened that my commits weren't verified so my work couldn't be merged what i did is i undo all the commits from the PR closed it and created another PR which is this one

@Ogenbertrand tag @stephane-segning when you are writing a comment if not, he won't see it

@stephane-segning
Copy link
Contributor

stephane-segning commented Apr 8, 2024

The ticket's name is fea/service worker, but where is it?

Hello sir the fea/service worker branch was merged in the main branch already, after the the merging was done it happened that one test was failing from the main branch which is the "build test". So what i did was i navigated to the main branch and started debugging from there which i ended up fixing the fault and i created a new PR.

After creating the new PR from the main branch it happened that my commits weren't verified so my work couldn't be merged what i did is i undo all the commits from the PR closed it and created another PR which is this one

It's a nice story but not interesting @Ogenbertrand. This PR is created under a specific name. But that name does not match the implementation. Try fixing that

@Ogenbertrand Ogenbertrand changed the title fea/service worker Fix the "docker build error" Apr 8, 2024
@Ogenbertrand Ogenbertrand changed the title Fix the "docker build error" Update the OKPage.tsx file. Apr 8, 2024
@Ogenbertrand
Copy link
Collaborator Author

The ticket's name is fea/service worker, but where is it?

Hello sir the fea/service worker branch was merged in the main branch already, after the the merging was done it happened that one test was failing from the main branch which is the "build test". So what i did was i navigated to the main branch and started debugging from there which i ended up fixing the fault and i created a new PR.

After creating the new PR from the main branch it happened that my commits weren't verified so my work couldn't be merged what i did is i undo all the commits from the PR closed it and created another PR which is this one

It's a nice story but not interesting @Ogenbertrand. This PR is created under a specific name. But that name does not match the implementation. Try fixing that

Okay sir @stephane-segning. I just fixed it

@stephane-segning
Copy link
Contributor

The ticket's name is fea/service worker, but where is it?

Hello sir the fea/service worker branch was merged in the main branch already, after the the merging was done it happened that one test was failing from the main branch which is the "build test". So what i did was i navigated to the main branch and started debugging from there which i ended up fixing the fault and i created a new PR.

After creating the new PR from the main branch it happened that my commits weren't verified so my work couldn't be merged what i did is i undo all the commits from the PR closed it and created another PR which is this one

It's a nice story but not interesting @Ogenbertrand. This PR is created under a specific name. But that name does not match the implementation. Try fixing that

Okay sir @stephane-segning. I just fixed it

Then what are you updating here?

@Ogenbertrand Ogenbertrand reopened this Apr 9, 2024
@Ogenbertrand
Copy link
Collaborator Author

@stephane-segning
I Renamed the component OKpage to OKPage to maintain consistency,
Called the sendMoney() function within the useEffect() hook to trigger the API call when the component mounts,
Modified the component name in the export statement to match the component's name (OKPage).
Refactor OKPage component and fix API call

@stephane-segning stephane-segning merged commit 079256f into ADORSYS-GIS:main Apr 12, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants