Use Either for error handling

[sstone]

We already export an Either type, which can be reused by clients of this library.

[t-bast]

I guess the goal is to delete the corresponding class from lightning-kmp when we update it to use this version of bitcoin-kmp, right? In that case we should also import the Try implementation, this way we remove it as well from lightning-kmp, otherwise it would be weird to keep one in lightning-kmp and the other in bitcoin-kmp?

[sstone]

I guess the goal is to delete the corresponding class from lightning-kmp when we update it to use this version of bitcoin-kmp, right? In that case we should also import the Try implementation, this way we remove it as well from lightning-kmp, otherwise it would be weird to keep one in lightning-kmp and the other in bitcoin-kmp?

Done in 7af325c, though I believe that we may not need it: API methods in lightning-kmp should use Either, and internal methods could just use kotlin's built-in Result type

[t-bast]

LGTM, I believe we can revert the version change and merge this 👍

[t-bast]

Done in 7af325c, though I believe that we may not need it: API methods in lightning-kmp should use Either, and internal methods could just use kotlin's built-in Result type

I agree with that, but inside lightning-kmp we do use Try in a few places, and it will be cleaner to use the one exported by bitcoin-kmp. Then maybe we can stop using Try altogether from ligthning-kmp if it doesn't make sense, but we can do that in a next step, no need to do it right now!

[sstone]

LGTM, I believe we can revert the version change and merge this 👍

done in e3ba135