fix: PEM header for generated public and private keys. #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
werwurm
requested review from
ChriMarMe,
zaolin,
walterchris,
PatrickRudolph and
ArthurHeymans
as code owners
Omiting the key type in the PEM header of the generated key leaves the key files malformed which confuses some parsers including openssl. Signed-off-by: Janis Danisevskis <[email protected]>
werwurm
force-pushed
the
fix_pem_header
branch
from
0e4b67b
to
8693fb6
Compare
werwurm
changed the title
werwurm
changed the title
zaolin
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Omiting the key type in the PEM header of the generated key leaves the key files malformed which confuses some parsers including openssl.