Add new endpoint to PATCH firewall rules #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of overwriting all firewall rules with the new set. Backend will go over each rule and only update the rule if there is a match on 'IP' field.
|
Used by draft PR cloudamqp/terraform-provider-cloudamqp#216 to try out patching firewall rules. |
dentarg
reviewed
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue with how multiple PATH firewall getting handled in the API backend. Process started to handle this with: https://github.com/84codes/account-console/commit/3a22a6671d0c286ca30f5fc399caaa14817e3206
WHY are these changes introduced?
Instead of overwrite all firewall rules, use API backend endpoint to patch one or more firewall rules and keep the rest as is.
Required by: cloudamqp/terraform-provider-cloudamqp#216
WHAT is this pull request doing?
HOW can this pull request be tested?
Tested against new Terraform Resource.