Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix types not being exported correctly #7

Merged
merged 1 commit into from
Nov 4, 2023
Merged

Conversation

ImLunaHey
Copy link
Contributor

I get this error otherwise.

#12 11.72 Type error: Could not find a declaration file for module 'react-powerglitch'. '/app/node_modules/react-powerglitch/lib/react-powerglitch.es.js' implicitly has an 'any' type.
#12 11.72   There are types at '/app/node_modules/react-powerglitch/types/lib/index.d.ts', but this result could not be resolved when respecting package.json "exports". The 'react-powerglitch' library may need to update its package.json or typings.

@7PH 7PH self-requested a review November 4, 2023 11:07
@7PH 7PH changed the title fix: types not being exported correctly Fix types not being exported correctly Nov 4, 2023
Copy link
Owner

@7PH 7PH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That does make it work in case you have moduleResolution: bundler is set in your tsconfig. Thanks for the fix, I will propagate it into a new react-powerglitch version

@7PH 7PH merged commit ad29efd into 7PH:master Nov 4, 2023
3 checks passed
@7PH 7PH added the bug Something isn't working label Nov 4, 2023
@7PH
Copy link
Owner

7PH commented Nov 4, 2023

This is now fixed and published with [email protected]

Thank you for your contribution @ImLunaHey

@ImLunaHey ImLunaHey deleted the patch-1 branch November 5, 2023 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants