When duplicating a project, ask for the new name and if link with game should be kept #7253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
AlexandreSi
commented
Dec 19, 2024
AlexandreSi
commented
… new game as well
4ian
reviewed
Dec 19, 2024
| @@ -314,7 +314,7 @@ const CreateSection = ({ | |||
| const isCurrentProjectOpened = | |||
| !!project && | |||
| !!currentFileMetadata && | |||
| fileMetadata.gameId === currentFileMetadata.gameId; | |||
| fileMetadata.fileIdentifier === currentFileMetadata.fileIdentifier; | |||
| let originalProjectUuid = null; | ||
| if (newSaveAsOptions && newSaveAsOptions.generateNewProjectUuid) { | ||
| originalProjectUuid = currentProject.getProjectUuid(); | ||
| currentProject.resetProjectUuid(); |
There was a problem hiding this comment.
just double checking this will not affect the initial project? I assume not as we're not saving that project
There was a problem hiding this comment.
In my tests everything went fine, but I'll check again
There was a problem hiding this comment.
I confirm it's okay
newIDE/app/src/ProjectsStorage/CloudStorageProvider/CloudProjectWriter.js
Outdated
Show resolved
Hide resolved
| @@ -243,7 +251,7 @@ export const generateOnSaveProjectAs = ( | |||
| } | |||
| options.onStartSaving(); | |||
|
|
|||
| const gameId = saveAsLocation.gameId || project.getProjectUuid(); | |||
There was a problem hiding this comment.
why this change? was this not used?
There was a problem hiding this comment.
I saw it used only once, above in generateOnChooseSaveProjectAsLocation. I felt like it was not onChooseSaveProjectAsLocation role to set the gameId. So I removed it.
newIDE/app/src/ProjectsStorage/LocalFileStorageProvider/LocalProjectWriter.js
Outdated
Show resolved
Hide resolved
4ian
approved these changes
Dec 19, 2024
4ian
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.