Add 3D physics and 3D character behaviors #7149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4ian
reviewed
Nov 12, 2024
D8H
force-pushed
the
3d-physics
branch
4 times, most recently
from
e02c17b to
b041073
Compare
4ian
reviewed
Dec 11, 2024
4ian
reviewed
Dec 11, 2024
4ian
reviewed
Dec 11, 2024
4ian
reviewed
Dec 11, 2024
|
|
||
| aut | ||
| .addScopedAction( | ||
| 'SimulateForwardKey', |
There was a problem hiding this comment.
Open question: I wonder if we should have a single "SimulateKey" that takes a key as a parameter.
There was a problem hiding this comment.
Probably at some point, but we can't remove or rename a choice from stringWithSelector without creating a new instruction so I prefer not to do it until we are sure about the controls.
4ian
reviewed
Dec 11, 2024
| props: PhysicsCharacter3DNetworkSyncDataType; | ||
| } | ||
|
|
||
| type Physics3D = { |
There was a problem hiding this comment.
A bit of a strange name for a type and an object no?
There was a problem hiding this comment.
Maybe Physics3DContext?
D8H
changed the title
D8H
changed the title
4ian
reviewed
Dec 11, 2024
| // It's possible the behavior was either deactivated or the object deleted | ||
| // just before this doStepPreEvents (for example, another behavior deleted | ||
| // the object during its own doStepPreEvents). If the body is null, we just | ||
| // don't do anything (but still run the physics simulation - this is independent). |
There was a problem hiding this comment.
The parenthesis comment is useless now. And in 2D only, since you've reworked how this code works
4ian
reviewed
Dec 11, 2024
| physics3DHook.doBeforePhysicsStep(deltaTime); | ||
| } | ||
|
|
||
| const numSteps = deltaTime > 1.0 / 55.0 ? 2 : 1; |
There was a problem hiding this comment.
Do we support 2 steps at once? I'm surprised
4ian
reviewed
Dec 12, 2024
4ian
reviewed
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Demo