-
Notifications
You must be signed in to change notification settings - Fork 863
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return picked instances from events-based free functions #5823
base: master
Are you sure you want to change the base?
Conversation
Glad to see this is back on track :D |
83cd1e8
to
3bc8b18
Compare
As explained, in the following comment:
|
GDevelop.js/__tests__/GDJSAdvancedExtensionCodeGenerationIntegrationTests.js
Outdated
Show resolved
Hide resolved
I want to be sure to understand well this:
Here with this change:
My thinking is that 1) is the answer, because when you use "Create", you've not run any condition on the object before (it would not make sense. Well you can but these conditions will be false), so the "Create" will directly add the object to the object lists passed as parameter... is this correct? |
As discussed, let's add a test if two objects created in a function (using an object passed as parameter) and pick only the second thanks to this action, and see if it's properly "returned" to the caller. |
Follows: