Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix]: Fixed the bug in adding replies on Mattermost thread from Slack. #1574

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

[Fix]: Fixed the bug in adding replies on Mattermost thread from Slack. #1574

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
58f0bb6
[Fix]: Fixed bug in adding replies on mattermost thread from slack
avas27JTG Aug 24, 2021
1b0897e
[Fix]: used hasPrefix function
avas27JTG Aug 25, 2021
5fd0cb9
Merge branch 'master' of github.com:42wim/matterbridge into MI-1418
avas27JTG Aug 25, 2021
e9a71ae
[Fix]: Fixed lint error
avas27JTG Aug 31, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions bridge/mattermost/mattermost.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ package bmattermost
import (
"errors"
"fmt"
"strings"

"github.com/42wim/matterbridge/bridge"
"github.com/42wim/matterbridge/bridge/config"
Expand Down Expand Up @@ -129,11 +130,18 @@ func (b *Bmattermost) Send(msg config.Message) (string, error) {

// we only can reply to the root of the thread, not to a specific ID (like discord for example does)
if msg.ParentID != "" {
post, res := b.mc.Client.GetPost(msg.ParentID, "")
if res.Error != nil {
b.Log.Errorf("getting post %s failed: %s", msg.ParentID, res.Error.DetailedError)
rootID := msg.ParentID
// If parentID/rootID exists it means message is of reply type, so add 'thread' in message text
msg.Text = fmt.Sprintf("[thread]: %s", msg.Text)
// if text "mattermost" is present in the parentID/rootID (present in case root message is started on mattermost)
// separate it from the ID and use correct ID as parentID/rootID
if strings.HasPrefix(rootID, "mattermost") {
rootID = rootID[len("mattermost")+1:] // remove the text 'mattermost' and space followed by it from ID
}
msg.ParentID = post.RootId

// Set rootID of reply message
// here 'msg.ParentID' is used, but this is stored as 'RootId' at mattermost, refer to function 'PostMessage' below
msg.ParentID = rootID
}

// Upload a file if it exists
Expand Down