delete annotations in the background #3887
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlledom
reviewed
Sep 13, 2024
| @@ -68,7 +68,7 @@ class Account < ApplicationRecord | |||
| [:files, { action: :delete, class_name: 'CMS::File' }], | |||
| [:builtin_pages, { action: :delete, class_name: 'CMS::BuiltinPage' }], | |||
| [:provided_groups, { action: :delete, class_name: 'CMS::Group' }] | |||
| ].freeze | |||
| ] | |||
There was a problem hiding this comment.
because we modify in the audited method, cannot modify frozen
There was a problem hiding this comment.
Actually we may better just append to the existing empty array here too.
| @@ -24,7 +24,7 @@ class Service < ApplicationRecord # rubocop:disable Metrics/ClassLength | |||
| :backend_api_configs, | |||
| :metrics, | |||
| [:proxy, { action: :destroy, has_many: false }] | |||
| ].freeze | |||
| ] | |||
There was a problem hiding this comment.
Same, why removing the freeze?
jlledom
reviewed
Sep 20, 2024
| @@ -8,6 +8,8 @@ def annotated | |||
| class_eval do | |||
| include Model | |||
| include ManagedBy | |||
|
|
|||
| background_deletion << :annotations | |||
There was a problem hiding this comment.
Maybe you can do this and don't remove the freeze?
Suggested change
| background_deletion << :annotations | |
| background_deletion = [*background_deletion, :annotations] |
There was a problem hiding this comment.
Also, what is this background deletion about?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This needs to be explored.