Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support emu accounts by adding EMU_SHORTCODE env var #173

Merged
merged 7 commits into from
Aug 14, 2023

Conversation

robandpdx
Copy link
Collaborator

If the variable EMU_SHORTCODE is set, then the shortcode is appended to the username found in okta

@robandpdx robandpdx requested a review from primetheus as a code owner August 11, 2023 18:37
shortcode is appended to the username found in okta
@Chocrates
Copy link
Contributor

Can we add this to https://github.com/robandpdx/github-team-sync/blob/emu-shortcode/githubapp/ldap.py#L67 and all other instances of the get_group_members methods?

Copy link
Contributor

@Chocrates Chocrates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we please add this to the other get_group_members methods

@robandpdx
Copy link
Collaborator Author

Can we please add this to the other get_group_members methods

Done ✅

@robandpdx robandpdx merged commit b3afb53 into 3rd-party-integrations:main Aug 14, 2023
@robandpdx robandpdx deleted the emu-shortcode branch August 14, 2023 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants