[Bugfix] Edition : exec a DELETE can return 0 in some cases #5093
+11
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rldhont
added
sponsored development
`jDbConnection::exec()` returns the number of affected rows or False if the query has failed. In some cases, for exemple a DELETE on a view or a DELETE catches by a trigger can return no affected rows. So lizmap has to rollback() executed requests only if a query has failed. Funded by Conseil Départemental du Calvados and Ville d'Avignon
rldhont
force-pushed
the
fix-delete-from-view-return-no-changes
branch
from
8c991d9 to
3ca18f4
Compare
mdouchin
approved these changes
Dec 11, 2024
This was referenced Dec 11, 2024
nboisteault
pushed a commit
to nboisteault/lizmap-web-client
that referenced
this pull request
Dec 12, 2024
…-no-changes [Bugfix] Edition : exec a DELETE can return 0 in some cases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jDbConnection::exec()returns the number of affected rows or False if the query has failed.In some cases, for exemple a
DELETEon a view or aDELETEcatched by a trigger, this method can return no affected rows. So Lizmap has torollback()executed requests only if a query has failed.Funded by Conseil Départemental du Calvados and Ville d'Avignon