Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Circular geometry measurement on draw #5079

Merged
merged 3 commits into from
Dec 9, 2024

Conversation

mind84
Copy link
Contributor

@mind84 mind84 commented Dec 4, 2024

ADDED FEATURES:

  • Add measure tooltip on circles with radius and area measurement
  • Initialize measure tooltips on features loaded from local storage

NOTES:

  • Circles area is calculated using the fromCirlce method of Openlayers Polygon class.
    There is another (more verbose) way to do it that involves circular method but requires to convert center and "last" coordinates in EPSG:4326.
    Given the same polygonal approximation (128 sides), the two methods return the same output so I decided to use the less verbose one.

  • For circles, the "segment" tooltip (radius) is no longer displayed near mouse pointer but it's displayed in the interior point of the feature, along with the area measure.

Feature preview:

circle_measurement.webm

Funded by Etra

@github-actions github-actions bot added this to the 3.10.0 milestone Dec 4, 2024
@rldhont
Copy link
Collaborator

rldhont commented Dec 4, 2024

Thanks @mind84, can you provide a print screen or a gif ?

@rldhont rldhont requested a review from nboisteault December 4, 2024 15:59
@nboisteault nboisteault added the run end2end If the PR must run end2end tests or not label Dec 5, 2024
@nboisteault nboisteault merged commit 42c0979 into 3liz:master Dec 9, 2024
20 checks passed
@mind84 mind84 deleted the circle_measurement branch December 10, 2024 07:49
nboisteault added a commit to nboisteault/lizmap-web-client that referenced this pull request Dec 12, 2024
[Feature] Circular geometry measurement on draw
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants