Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FeaturesTable structure & columns improvements #5013

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

FeaturesTable structure & columns improvements #5013

wants to merge 1 commit into from
+295 −63

Conversation

neo-garaix
Copy link
Contributor

@neo-garaix neo-garaix commented Nov 28, 2024 •
edited
Loading

Add

  • Replaced some "div" by "table" tags such as "tr", "th" ...
  • Added columns compatibility : now we can add several columns through some <lizmap-field ... > ... </lizmap-field>
  • Added header labels of columns
  • Added regex verification for expressions in fields. For now, we only accept expressions in fields like "libsquart" and not expressions like rand(10,34).
  • If fields have the same expression or aliases (except empty ones), only the first one is showed.

Fix

  • Fixed the end2end playwright test about FeaturesTable

Fix version of #4922

Funded by 3liz

@github-actions github-actions bot added this to the 3.10.0 milestone Nov 28, 2024
@mdouchin mdouchin added run end2end If the PR must run end2end tests or not backport release_3_9 enhancement user interface javascript Pull requests that update Javascript code labels Nov 28, 2024
@mdouchin mdouchin requested review from rldhont and mdouchin and removed request for rldhont November 28, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rldhont rldhont rldhont approved these changes

@mdouchin mdouchin Awaiting requested review from mdouchin

Assignees

@neo-garaix neo-garaix

Labels
backport release_3_9 enhancement javascript Pull requests that update Javascript code run end2end If the PR must run end2end tests or not user interface
Projects
None yet
Milestone
3.10.0
Development

Successfully merging this pull request may close these issues.
3 participants
@neo-garaix @rldhont @mdouchin